Make random more random than the google bot

This commit is contained in:
Runebaas 2018-02-14 23:01:28 +01:00
parent cabf942362
commit acc8947782
No known key found for this signature in database
GPG key ID: 2677AF508D0300D6
11 changed files with 20 additions and 43 deletions

View file

@ -7,10 +7,9 @@ namespace Geekbot.net.Lib.Media
internal class FortunesProvider : IFortunesProvider
{
private readonly string[] fortuneArray;
private readonly Random rnd;
private readonly int totalFortunes;
public FortunesProvider(Random rnd, IGeekbotLogger logger)
public FortunesProvider(IGeekbotLogger logger)
{
var path = Path.GetFullPath("./Storage/fortunes");
if (File.Exists(path))
@ -18,7 +17,6 @@ namespace Geekbot.net.Lib.Media
var rawFortunes = File.ReadAllText(path);
fortuneArray = rawFortunes.Split("%");
totalFortunes = fortuneArray.Length;
this.rnd = rnd;
logger.Debug("Geekbot", "Loaded {totalFortunes} Fortunes");
}
else
@ -29,7 +27,7 @@ namespace Geekbot.net.Lib.Media
public string GetRandomFortune()
{
return fortuneArray[rnd.Next(0, totalFortunes)];
return fortuneArray[new Random().Next(0, totalFortunes)];
}
}

View file

@ -17,9 +17,9 @@ namespace Geekbot.net.Lib.Media
private string[] _pumpkinImages;
private string[] _turtlesImages;
public MediaProvider(Random rnd, IGeekbotLogger logger)
public MediaProvider(IGeekbotLogger logger)
{
_random = rnd;
_random = new Random();
_logger = logger;
logger.Information("Geekbot", "Loading Media Files");