Add an abstraction for http calls

This commit is contained in:
runebaas 2020-07-15 02:52:13 +02:00
parent 0589b8e91b
commit ba0d116f3e
No known key found for this signature in database
GPG key ID: 2677AF508D0300D6
9 changed files with 75 additions and 135 deletions

View file

@ -1,12 +1,10 @@
using System;
using System.Net.Http;
using System.Threading.Tasks;
using Discord;
using Discord.Commands;
using Geekbot.net.Commands.Randomness.Cat;
using Geekbot.net.Lib;
using Geekbot.net.Lib.ErrorHandling;
using Geekbot.net.Lib.Extensions;
using Newtonsoft.Json;
namespace Geekbot.net.Commands.Randomness.Greetings
{
@ -26,7 +24,7 @@ namespace Geekbot.net.Commands.Randomness.Greetings
{
try
{
var greeting = await GetRandomGreeting();
var greeting = await HttpAbstractions.Get<GreetingBaseDto>(new Uri("https://api.greetings.dev/v1/greeting"));
var eb = new EmbedBuilder();
eb.Title = greeting.Primary.Text;
@ -49,18 +47,5 @@ namespace Geekbot.net.Commands.Randomness.Greetings
await _errorHandler.HandleCommandException(e, Context);
}
}
private async Task<GreetingBaseDto> GetRandomGreeting()
{
using var client = new HttpClient
{
BaseAddress = new Uri("https://api.greetings.dev")
};
var response = await client.GetAsync("/v1/greeting");
response.EnsureSuccessStatusCode();
var stringResponse = await response.Content.ReadAsStringAsync();
return JsonConvert.DeserializeObject<GreetingBaseDto>(stringResponse);
}
}
}