daan/geekbot
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Resharper suggestions

Browse source
This commit is contained in:
runebaas 2018-04-30 23:44:19 +02:00
parent b81284bfe7
commit cdb104cacc
No known key found for this signature in database
GPG key ID: 2677AF508D0300D6
55 changed files with 382 additions and 550 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Geekbot.net/Lib/Media/FortunesProvider.cs
View file

@ -1,13 +1,12 @@
using System;
using System.IO;
using Serilog;
namespace Geekbot.net.Lib.Media
{
internal class FortunesProvider : IFortunesProvider
{
private readonly string[] fortuneArray;
private readonly int totalFortunes;
private readonly string[] _fortuneArray;
private readonly int _totalFortunes;
public FortunesProvider(IGeekbotLogger logger)
{
@ -15,8 +14,8 @@ namespace Geekbot.net.Lib.Media
if (File.Exists(path))
{
var rawFortunes = File.ReadAllText(path);
fortuneArray = rawFortunes.Split("%");
totalFortunes = fortuneArray.Length;
_fortuneArray = rawFortunes.Split("%");
_totalFortunes = _fortuneArray.Length;
logger.Debug("Geekbot", "Loaded {totalFortunes} Fortunes");
}
else
@ -27,7 +26,7 @@ namespace Geekbot.net.Lib.Media
public string GetRandomFortune()
{
return fortuneArray[new Random().Next(0, totalFortunes)];
return _fortuneArray[new Random().Next(0, _totalFortunes)];
}
}

35
Geekbot.net/Lib/Media/MediaProvider.cs
View file

@ -1,8 +1,5 @@
using System;
using System.IO;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Serilog;
namespace Geekbot.net.Lib.Media
{
@ -92,42 +89,42 @@ namespace Geekbot.net.Lib.Media
_logger.Debug("Geekbot", $"Loaded {_foxImages.Length} Foxes Images");
}
public string getCheckem()
public string GetCheckem()
{
return _checkemImages[_random.Next(0, _checkemImages.Length)];
}
public string getPanda()
public string GetPanda()
{
return _pandaImages[_random.Next(0, _pandaImages.Length)];
}
public string getCrossant()
public string GetCrossant()
{
return _croissantImages[_random.Next(0, _croissantImages.Length)];
}
public string getSquirrel()
public string GetSquirrel()
{
return _squirrelImages[_random.Next(0, _squirrelImages.Length)];
}
public string getPumpkin()
public string GetPumpkin()
{
return _pumpkinImages[_random.Next(0, _pumpkinImages.Length)];
}
public string getTurtle()
public string GetTurtle()
{
return _turtlesImages[_random.Next(0, _turtlesImages.Length)];
}
public string getPinguin()
public string GetPinguin()
{
return _pinguinImages[_random.Next(0, _pinguinImages.Length)];
}
public string getFox()
public string GetFox()
{
return _foxImages[_random.Next(0, _foxImages.Length)];
}
@ -135,13 +132,13 @@ namespace Geekbot.net.Lib.Media
public interface IMediaProvider
{
string getCheckem();
string getPanda();
string getCrossant();
string getSquirrel();
string getPumpkin();
string getTurtle();
string getPinguin();
string getFox();
string GetCheckem();
string GetPanda();
string GetCrossant();
string GetSquirrel();
string GetPumpkin();
string GetTurtle();
string GetPinguin();
string GetFox();
}
}